From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [Virtio-for-kvm] [PATCH 7/7] userspace virtio Date: Wed, 02 Jan 2008 19:22:27 +0200 Message-ID: <477BC853.405@qumranet.com> References: <476BD1A9.2040701@qumranet.com> <477BB5D2.6010304@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel , virtualization To: Anthony Liguori Return-path: In-Reply-To: <477BB5D2.6010304-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Anthony Liguori wrote: > I think we should hold off on this sort of patch at first. I know it > improves performance, but it's very hack-ish. I have a similar patch[1] > that improves performance more but is even more hack-ish. > > I think we have to approach this by not special cases virtio-net to know > about the tap fd, but to figure out the interface that virtio-net would > need to be efficient, and then refactor the net interface to look like > that. Then we can still support user, pcap, and the other network > transports. > > [1] http://hg.codemonkey.ws/qemu-virtio/file/75cefe566cea/aio-net.diff > While you are right in principle, high performance networking is long overdue in kvm so I applied that patch. Once a mega async dma framework is added to qemu, we'll just revert that patch prior to adding the glue to said framework. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/