Re: [Virtio-for-kvm] [PATCH 7/7] userspace virtio

[Dor Laor <dor.laor-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

Avi Kivity wrote:
> Anthony Liguori wrote:
>> I think we should hold off on this sort of patch at first.  I know it 
>> improves performance, but it's very hack-ish.  I have a similar 
>> patch[1] that improves performance more but is even more hack-ish.
>>
>> I think we have to approach this by not special cases virtio-net to 
>> know about the tap fd, but to figure out the interface that 
>> virtio-net would need to be efficient, and then refactor the net 
>> interface to look like that.  Then we can still support user, pcap, 
>> and the other network transports.
>>
>> [1] http://hg.codemonkey.ws/qemu-virtio/file/75cefe566cea/aio-net.diff
>>   
>
> While you are right in principle, high performance networking is long 
> overdue in kvm so I applied that patch.  Once a mega async dma 
> framework is added to qemu, we'll just revert that patch prior to 
> adding the glue to said framework.
>
I second Avi, the reason we wanted quick (and ugly) performance patch 
merged was because people are trying kvm and sometime
get disappointed of IO performance. Since we did have unmerged pv net 
for quite a while, we're pushing towards merging it.
We can't wait for qemu guys to merge it and we also plan to develop host 
kernel pv network side.

btw: My hack leaves the -user support but with the previous performance.
I'll add the tx improvement too.

Thanks for the backward compat patch :)
Dor

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/