From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: "Dong, Eddie" <eddie.dong-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: kvm-devel <kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: remove redundant VM Exit for non-aligned guest pte write or part of pte write.
Date: Sun, 06 Jan 2008 10:50:56 +0200 [thread overview]
Message-ID: <47809670.9090706@qumranet.com> (raw)
In-Reply-To: <10EA09EFD8728347A513008B6B0DA77A029B5503-wq7ZOvIWXbNpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
Dong, Eddie wrote:
> Avi Kivity wrote:
>
>> Dong, Eddie wrote:
>>
>>> I observed 1-2 seconds faster in Windows XPSP2 ACPI bootup with
>>> total of 23 seconds.
>>> I can;t say it is exactly caused by this patch, but anyway it
>>> simplifies the logic and code w/o any additional complexity.
>>> thx,eddie
>>>
>>>
>>>
>>>
>> Patch looks good, but will delay so that the guest scaling patch can
>> be merged. kvm_read_guest() will need to change to
>> kvm_read_guest_inatomic(), since the mmu is becoming spinlocked.
>>
>
> Rebased.
> Thx, eddie
>
> A guest non-aligned pte write or part of pte
> update will leave shadow_trap_nonpresent_pte
> in spte, which expects a new VM Exit at next
> access time.
>
> This patch fixed this by reading guest pte
> in advance and thus be able to update spte
> and reduce next VM Exit.
>
>
Wrong patch attached...
--
error compiling committee.c: too many arguments to function
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
next prev parent reply other threads:[~2008-01-06 8:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-20 8:51 remove redundant VM Exit for non-aligned guest pte write or part of pte write Dong, Eddie
[not found] ` <10EA09EFD8728347A513008B6B0DA77A028A6DB2-wq7ZOvIWXbNpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2007-12-20 9:21 ` Avi Kivity
[not found] ` <476A3436.1000900-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2008-01-04 6:14 ` Dong, Eddie
[not found] ` <10EA09EFD8728347A513008B6B0DA77A029B5503-wq7ZOvIWXbNpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2008-01-06 8:50 ` Avi Kivity [this message]
[not found] ` <47809670.9090706-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2008-01-06 13:59 ` Dong, Eddie
[not found] ` <10EA09EFD8728347A513008B6B0DA77A029B57CD-wq7ZOvIWXbNpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2008-01-07 9:15 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47809670.9090706@qumranet.com \
--to=avi-atkuwr5tajbwk0htik3j/w@public.gmane.org \
--cc=eddie.dong-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox