From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: acpi sci polarity Date: Sun, 06 Jan 2008 11:08:31 +0200 Message-ID: <47809A8F.5090803@qumranet.com> References: <20080103181132.GA1077@bogon.ms20.nix> <20080103181415.GB1077@bogon.ms20.nix> <477D50FE.4040104@qumranet.com> <20080104183158.GA14002@bogon.ms20.nix> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Guido Guenther Return-path: In-Reply-To: <20080104183158.GA14002-DVvpyRRQz99DDGxTMhc9XQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Guido Guenther wrote: > Hi Avi, > On Thu, Jan 03, 2008 at 11:17:50PM +0200, Avi Kivity wrote: > >> While pci interrupts are documented as active high, the documentation for >> the piix4 pic elcr registers suggests piix4 level-triggered interrupts are >> active high. So there is some inconsistency somewhere involving qemu >> interrupt generation (which IIRC treats all interrupts as active high), the >> ioapic (qemu doesn't implement polarity), bios setup, and the acpi dsdt. >> > We currently specify INT10 as active high in the dsl so I added an > override entry to the madt an now the OS knows about it and things work > as expected - we this be o.k. until all the IRQ setup gets a revamp: > > >From 7950892de473d42ce57e0727594190b4bfafab14 Mon Sep 17 00:00:00 2001 > From: Guido Guenther > Date: Fri, 4 Jan 2008 19:26:33 +0100 > Subject: [PATCH] int 10 is currently active high > > so add a proper interrupt override entry to the MADT so the OS knows about it. > Fixes the ACPI powerbutton and should also fix the PM timer. > Since it is the OS that assigns SCI to irq10, we can't be sure it will always be there. So I think all PCI IRQs need such an override. Also, does this work if you remove the sci hack in piix3_set_irq() piix3_dev->config[0x60 + irq_num] &= ~0x80; // enable bit ? -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/