From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 02/33] KVM: MMU: emulated cmpxchg8b should be atomic on i386 Date: Mon, 07 Jan 2008 11:24:30 +0200 Message-ID: <4781EFCE.8000800@qumranet.com> References: <1199630379-28638-1-git-send-email-avi@qumranet.com> <1199630379-28638-3-git-send-email-avi@qumranet.com> <20080106185728.GA21491@tapir> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Marcelo Tosatti , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Carlo Marcelo Arenas Belon Return-path: In-Reply-To: <20080106185728.GA21491@tapir> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Carlo Marcelo Arenas Belon wrote: > On Sun, Jan 06, 2008 at 04:39:08PM +0200, Avi Kivity wrote: > >> From: Marcelo Tosatti >> >> Emulate cmpxchg8b atomically on i386. This is required to avoid a guest >> pte walker from seeing a splitted write. >> >> [avi: make it compile] >> >> Signed-off-by: Marcelo Tosatti >> Signed-off-by: Avi Kivity >> --- >> > > This one doesn't look like the one in the current tree, and avoids the reuse > of addr by moving the call to get the gpa up instead of renaming the variable > as propossed in : > > This is a cumulative patch that is the original patch plus all the fixes rolled in. I'd to avoid churn for style issues at this point, maybe we can address it later. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/