From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] qemu: use statically allocate 512 byte buffer in the stack for sector in bdrv_commit Date: Mon, 07 Jan 2008 11:27:42 +0200 Message-ID: <4781F08E.8060407@qumranet.com> References: <20080104071138.GB9285@tapir> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Laurent Vivier To: Carlo Marcelo Arenas Belon Return-path: In-Reply-To: <20080104071138.GB9285@tapir> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Carlo Marcelo Arenas Belon wrote: > revert a merge conflict from 075da586c92f09bd9a7401f1e80d72fde27c173 that > redefined sector as an array of pointers to char, instead of a statically > allocated buffer of chars, that was triggering the following warnings : > > block.c: In function `bdrv_commit': > block.c:480: warning: passing arg 3 of `bdrv_read' from incompatible pointer type > block.c:484: warning: passing arg 3 of `bdrv_write' from incompatible pointer type > > Signed-off-by: Carlo Marcelo Arenas Belon > Doesn't the cache=off option warrant an allocation here to ensure alignment (or perhaps a 1K stack buffer with runtime adjustment)? -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/