From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] qemu: use statically allocate 512 byte buffer in the stack for sector in bdrv_commit Date: Mon, 07 Jan 2008 20:27:32 +0200 Message-ID: <47826F14.6050504@qumranet.com> References: <20080104071138.GB9285@tapir> <4781F08E.8060407@qumranet.com> <1199701358.19008.1.camel@frecb07144> <4782034C.4000805@qumranet.com> <1199719004.23380.22.camel@frecb07144> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel , Carlo Marcelo Arenas Belon To: Laurent Vivier Return-path: In-Reply-To: <1199719004.23380.22.camel@frecb07144> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Laurent Vivier wrote: > What I'm wondering now is: is it really useful to have "cache=off" and > "snapshot=on" at the same time ? > No idea, but wouldn't want to rule it out. > If not, the patch of Carlo is good, otherwise there is more > modifications to do (in other parts of qemu). > If other modifications are needed, perhaps do them in the I/O submission path (if unaligned and cache=off, force alignment). Since most of the data will be aligned by the guest, the overhead will only be incurred by the rare metadata accesses. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace