Re: [PATCH] kvm guest balloon driver

[Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>]

Anthony Liguori wrote:
> BTW, I don't think the target should be a config value.  You don't gain 
> anything from it being in the config space and it's somewhat unnatural 
> for a virtio device.  It makes more sense as a message to the guest.
>   

I disagree. The target is state, not an individual item that needs to be 
acted on. Having it as a single variable means that multiple changes are 
collapsed automatically, and that the the setting survives module reload.

It's like a volume control, it doesn't send messages when you turn it, 
it just sets a value.

(maybe a thermostat knob is a better analogy, with the driver being the 
circuitry around the knob that tries to control the temperature to match 
the setting)

I believe state-like controls will be useful for other settings, like 
ethernet link state.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace