From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] kvm guest balloon driver Date: Tue, 08 Jan 2008 18:36:30 +0200 Message-ID: <4783A68E.80901@qumranet.com> References: <20080108153356.GA21726@dmt> <478399D5.9030707@codemonkey.ws> <20080108161005.GA22168@dmt> <4783A14A.3080605@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm-devel , virtualization-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Anthony Liguori Return-path: In-Reply-To: <4783A14A.3080605-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Anthony Liguori wrote: > BTW, I don't think the target should be a config value. You don't gain > anything from it being in the config space and it's somewhat unnatural > for a virtio device. It makes more sense as a message to the guest. > I disagree. The target is state, not an individual item that needs to be acted on. Having it as a single variable means that multiple changes are collapsed automatically, and that the the setting survives module reload. It's like a volume control, it doesn't send messages when you turn it, it just sets a value. (maybe a thermostat knob is a better analogy, with the driver being the circuitry around the knob that tries to control the temperature to match the setting) I believe state-like controls will be useful for other settings, like ethernet link state. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace