From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 2 of 2] Add PowerPC kvmctl harness and fix building the testcases Date: Wed, 09 Jan 2008 10:50:58 +0200 Message-ID: <47848AF2.5060809@qumranet.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, kvm-ppc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Hollis Blanchard Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Hollis Blanchard wrote: > + > +static int misc_init(void) > +{ > + int err; > + > + err = io_table_register(&pio_table, 0xff, 1, misc_io, NULL); > + if (err < 0) > + return err; > + > + err = io_table_register(&pio_table, 0xf1, 1, misc_io, NULL); > + if (err < 0) > + return err; > + > + err = io_table_register(&pio_table, 0xf4, 1, misc_io, NULL); > + if (err < 0) > + return err; > + > + return io_table_register(&pio_table, 0xd1, 1, misc_io, NULL); > +} > I thought ppc doesn't have pio (and certainly doesn't need the random hacks above)? While it's okay to not share code with x86 for the test harness, at least remove the x86 specific parts. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace