From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Otte Subject: Re: architecture-specific data in struct kvm_run ? Date: Thu, 10 Jan 2008 09:30:04 +0100 Message-ID: <4785D78C.7060405@de.ibm.com> References: <1199920800.5637.58.camel@basalt> Reply-To: carsteno-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel , Carsten Otte , "Zhang, Xiantao" To: Hollis Blanchard Return-path: In-Reply-To: <1199920800.5637.58.camel@basalt> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Hollis Blanchard wrote: > There are a bunch of x86-specific fields in struct kvm_run: > /* in */ > __u8 request_interrupt_window; > __u8 padding1[7]; > > /* out */ > __u8 if_flag; > __u8 padding2[2]; > > /* in (pre_kvm_run), out (post_kvm_run) */ > __u64 cr8; > __u64 apic_base; > > Since this structure is shared with all architectures, can we find a > more appropriate place to keep this data? Or should we feel free to add > arch-specific data here? Afaics, we'll need an arch extension to kvm_run. On s390, we'll need different extensions then x86 has defined here. And we don't need any of above fields. Carsten ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace