From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: architecture-specific data in struct kvm_run ? Date: Thu, 10 Jan 2008 11:47:02 +0200 Message-ID: <4785E996.2040008@qumranet.com> References: <1199920800.5637.58.camel@basalt> <42DFA526FC41B1429CE7279EF83C6BDCC08A9F@pdsmsx415.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel , Carsten Otte , Hollis Blanchard To: "Zhang, Xiantao" Return-path: In-Reply-To: <42DFA526FC41B1429CE7279EF83C6BDCC08A9F-wq7ZOvIWXbMAbVU2wMM1CrfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Zhang, Xiantao wrote: > Hollis Blanchard wrote: > >> There are a bunch of x86-specific fields in struct kvm_run: >> /* in */ >> __u8 request_interrupt_window; >> __u8 padding1[7]; >> >> /* out */ >> __u8 if_flag; >> __u8 padding2[2]; >> >> /* in (pre_kvm_run), out (post_kvm_run) */ >> __u64 cr8; >> __u64 apic_base; >> >> Since this structure is shared with all architectures, can we find a >> more appropriate place to keep this data? Or should we feel free to >> add arch-specific data here? >> > Hollis, > > Maybe #ifdef is enough if we other archs doesn't need to add new more. > For IA64, we don't require new fields. > > I agree, ifdefs are best here. Maybe wrap them in a structure. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace