compile error

compile error

[Zhao, Yunfeng]

Today's tip fails to compile with following error messages:


/workspace/ia32e/nightly/kvm-master-2.6.22-rc4-20080109010121401/kvm-use
rspace/qemu/../libkvm  -DCONFIG_X86 -Wall -O2 -g -fno-strict-aliasing
-I.
-I/workspace/ia32e/nightly/kvm-master-2.6.22-rc4-20080109010121401/kvm-u
serspace/qemu -MMD -MP -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64
-D_LARGEFILE_SOURCE
-I/workspace/ia32e/nightly/kvm-master-2.6.22-rc4-20080109010121401/kvm-u
serspace/qemu/slirp -DQEMU_IMG    -c -o qemu-img-block-raw-posix.o
block-raw-posix.c
In file included from /usr/include/linux/cdrom.h:14,
                 from block-raw-posix.c:52:
/workspace/ia32e/nightly/kvm-master-2.6.22-rc4-20080109010121401/kvm-use
rspace/qemu/../libkvm/asm/byteorder.h:9: error: syntax error before
"__u64"
/workspace/ia32e/nightly/kvm-master-2.6.22-rc4-20080109010121401/kvm-use
rspace/qemu/../libkvm/asm/byteorder.h:15: error: syntax error before
"__u32"
make[1]: *** [qemu-img-block-raw-posix.o] Error 1
make[1]: Leaving directory
`/workspace/ia32e/nightly/kvm-master-2.6.22-rc4-20080109010121401/kvm-us
erspace/qemu'
make: *** [qemu] Error 2

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace

Re: compile error

[Avi Kivity]

Zhao, Yunfeng wrote:
> Today's tip fails to compile with following error messages:
>   

[...]

Fixed now.  Hollis, I had to revert your asm symlink patch to fix this, 
so we need to find an alternative solution to that problem.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace

Re: compile error

[Hollis Blanchard]

On Wed, 2008-01-09 at 10:39 +0200, Avi Kivity wrote:
> Zhao, Yunfeng wrote:
> > Today's tip fails to compile with following error messages:
> >   
> 
> [...]
> 
> Fixed now.  Hollis, I had to revert your asm symlink patch to fix this, 
> so we need to find an alternative solution to that problem.

qemu ends up including <asm/byteorder.h> from /usr.

libkvm, on the other hand, ends up including <asm/kvm.h> from the target
kernel tree.

Since the two components are meaning completely different things when
referring to the "asm" directory, we should use different include paths.
The best long-term solution would probably be to remove "-I
$(KERNELDIR)/include" from libkvm, and instead build against a copy of
the KVM headers (maybe copied over with that "make sync" target?).

Avi, I think you're responsible for all the build directory munging we
do currently; what do you think about that?

-- 
Hollis Blanchard
IBM Linux Technology Center


-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace

Re: compile error

[Avi Kivity]

Hollis Blanchard wrote:
> On Wed, 2008-01-09 at 10:39 +0200, Avi Kivity wrote:
>   
>> Zhao, Yunfeng wrote:
>>     
>>> Today's tip fails to compile with following error messages:
>>>   
>>>       
>> [...]
>>
>> Fixed now.  Hollis, I had to revert your asm symlink patch to fix this, 
>> so we need to find an alternative solution to that problem.
>>     
>
> qemu ends up including <asm/byteorder.h> from /usr.
>
> libkvm, on the other hand, ends up including <asm/kvm.h> from the target
> kernel tree.
>
> Since the two components are meaning completely different things when
> referring to the "asm" directory, we should use different include paths.
> The best long-term solution would probably be to remove "-I
> $(KERNELDIR)/include" from libkvm, and instead build against a copy of
> the KVM headers (maybe copied over with that "make sync" target?).
>
> Avi, I think you're responsible for all the build directory munging we
> do currently; what do you think about that?
>   

I agree.

The traditional way is to build against installed headers; but we don't 
want to do that at this stage.  So your suggestion is the closest 
thing.  But we should make the sync target implicit so users don't have 
that additional step.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace

compile error

[Zhao, Yunfeng]

[-- Attachment #1.1: Type: text/plain, Size: 910 bytes --]

Today's IA32e KVM build fails, here is the error message:

libqemu.a(kvm-tpr-opt.o): In function `enable_vapic':

/workspace/ia32e/nightly/kvm-master-2.6.22-rc4-20080218000132559/kvm-use
rspace/qemu/kvm-tpr-opt.c:232: undefined reference to `kvm_enable_vapic'

libqemu.a(kvm-tpr-opt.o): In function `kvm_tpr_vcpu_start':

/workspace/ia32e/nightly/kvm-master-2.6.22-rc4-20080218000132559/kvm-use
rspace/qemu/kvm-tpr-opt.c:302: undefined reference to
`kvm_enable_tpr_access_reporting'

collect2: ld returned 1 exit status

make[2]: *** [qemu-system-x86_64] Error 1

make[2]: Leaving directory
`/workspace/ia32e/nightly/kvm-master-2.6.22-rc4-20080218000132559/kvm-us
erspace/qemu/x86_64-softmmu'

make[1]: *** [subdir-x86_64-softmmu] Error 2

make[1]: Leaving directory
`/workspace/ia32e/nightly/kvm-master-2.6.22-rc4-20080218000132559/kvm-us
erspace/qemu'

make: *** [qemu] Error 2


[-- Attachment #1.2: Type: text/html, Size: 3692 bytes --]

[-- Attachment #2: Type: text/plain, Size: 228 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

[-- Attachment #3: Type: text/plain, Size: 158 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel

Re: compile error

[Avi Kivity]

Zhao, Yunfeng wrote:
>
> Today’s IA32e KVM build fails, here is the error message:
>
> libqemu.a(kvm-tpr-opt.o): In function `enable_vapic':
>
> /workspace/ia32e/nightly/kvm-master-2.6.22-rc4-20080218000132559/kvm-userspace/qemu/kvm-tpr-opt.c:232: 
> undefined reference to `kvm_enable_vapic'
>
> libqemu.a(kvm-tpr-opt.o): In function `kvm_tpr_vcpu_start':
>
> /workspace/ia32e/nightly/kvm-master-2.6.22-rc4-20080218000132559/kvm-userspace/qemu/kvm-tpr-opt.c:302: 
> undefined reference to `kvm_enable_tpr_access_reporting'
>
> collect2: ld returned 1 exit status
>
> make[2]: *** [qemu-system-x86_64] Error 1
>
> make[2]: Leaving directory 
> `/workspace/ia32e/nightly/kvm-master-2.6.22-rc4-20080218000132559/kvm-userspace/qemu/x86_64-softmmu'
>
> make[1]: *** [subdir-x86_64-softmmu] Error 2
>
> make[1]: Leaving directory 
> `/workspace/ia32e/nightly/kvm-master-2.6.22-rc4-20080218000132559/kvm-userspace/qemu'
>
> make: *** [qemu] Error 2
>

I can't reproduce this with the last snapshot.  What commits hashes are 
you using?

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel

Re: compile error

[Zhao, Yunfeng]

I am using TIP.
I found that if try to compile twice, the first time has no problem but
the second time (make clean&&./configure&&make) will meet the error.

>>
>
>I can't reproduce this with the last snapshot.  What commits hashes are
>you using?
>
>--
>Do not meddle in the internals of kernels, for they are subtle and
quick to panic.


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

Re: compile error

[Avi Kivity]

Zhao, Yunfeng wrote:
> I am using TIP.
> I found that if try to compile twice, the first time has no problem but
> the second time (make clean&&./configure&&make) will meet the error.
>
>   

Yes, 'make clean' was too eager.  Fixed.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

Compile error

[Zhao, Yunfeng]

I meet the error below when I compile KVM module against
30dac03825e830641054a829fe99ff6d1f2ebe0d. The kernel is 2.6.22-rc4.

+ make -C kernel
make[1]: Entering directory
`/workspace/ia32e/nightly/kvm-master-2.6.22-rc4-20070708190117/kvm-users
pace/BUILD/kernel'
make -j20 -C /lib/modules/2.6.22-rc4/build M=`pwd` "$@"
make[2]: Entering directory
`/usr/src/redhat/BUILD/kernel-2.6.22rc4g85f6038f'
  LD
/workspace/ia32e/nightly/kvm-master-2.6.22-rc4-20070708190117/kvm-usersp
ace/BUILD/kernel/built-in.o
  CC [M]
/workspace/ia32e/nightly/kvm-master-2.6.22-rc4-20070708190117/kvm-usersp
ace/BUILD/kernel/svm.o
  CC [M]
/workspace/ia32e/nightly/kvm-master-2.6.22-rc4-20070708190117/kvm-usersp
ace/BUILD/kernel/vmx.o
  CC [M]
/workspace/ia32e/nightly/kvm-master-2.6.22-rc4-20070708190117/kvm-usersp
ace/BUILD/kernel/vmx-debug.o
  CC [M]
/workspace/ia32e/nightly/kvm-master-2.6.22-rc4-20070708190117/kvm-usersp
ace/BUILD/kernel/kvm_main.o
  CC [M]
/workspace/ia32e/nightly/kvm-master-2.6.22-rc4-20070708190117/kvm-usersp
ace/BUILD/kernel/mmu.o
  CC [M]
/workspace/ia32e/nightly/kvm-master-2.6.22-rc4-20070708190117/kvm-usersp
ace/BUILD/kernel/x86_emulate.o
  CC [M]
/workspace/ia32e/nightly/kvm-master-2.6.22-rc4-20070708190117/kvm-usersp
ace/BUILD/kernel/anon_inodes.o
/workspace/ia32e/nightly/kvm-master-2.6.22-rc4-20070708190117/kvm-usersp
ace/BUILD/kernel/kvm_main.c: In function 'kvm_cpu_hotplug':
/workspace/ia32e/nightly/kvm-master-2.6.22-rc4-20070708190117/kvm-usersp
ace/BUILD/kernel/kvm_main.c:3007: error: 'CPU_DYING' undeclared (first
use in this function)
/workspace/ia32e/nightly/kvm-master-2.6.22-rc4-20070708190117/kvm-usersp
ace/BUILD/kernel/kvm_main.c:3007: error: (Each undeclared identifier is
reported only once
/workspace/ia32e/nightly/kvm-master-2.6.22-rc4-20070708190117/kvm-usersp
ace/BUILD/kernel/kvm_main.c:3007: error: for each function it appears
in.)
/workspace/ia32e/nightly/kvm-master-2.6.22-rc4-20070708190117/kvm-usersp
ace/BUILD/kernel/kvm_main.c:3008: error: 'CPU_DYING_FROZEN' undeclared
(first use in this function)
/workspace/ia32e/nightly/kvm-master-2.6.22-rc4-20070708190117/kvm-usersp
ace/BUILD/kernel/kvm_main.c:3013: warning: implicit declaration of
function 'on_cpu'
make[3]: ***
[/workspace/ia32e/nightly/kvm-master-2.6.22-rc4-20070708190117/kvm-users
pace/BUILD/kernel/kvm_main.o] Error 1
make[3]: *** Waiting for unfinished jobs....

How can I fix this issue?


Thanks
Yunfeng

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

Re: Compile error

[Avi Kivity]

Zhao, Yunfeng wrote:
> I meet the error below when I compile KVM module against
> 30dac03825e830641054a829fe99ff6d1f2ebe0d. The kernel is 2.6.22-rc4.
> /workspace/ia32e/nightly/kvm-master-2.6.22-rc4-20070708190117/kvm-usersp
> ace/BUILD/kernel/kvm_main.c: In function 'kvm_cpu_hotplug':
> /workspace/ia32e/nightly/kvm-master-2.6.22-rc4-20070708190117/kvm-usersp
> ace/BUILD/kernel/kvm_main.c:3007: error: 'CPU_DYING' undeclared (first
> use in this function)
>   

> How can I fix this issue?
>
>   

Pull from kvm-userspace.git; I forgot to push the last userspace changes.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.


-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

Re: debug and breakpoint interrupts handling?

[Jun Koi]

On 6/28/07, Dor Laor <dor.laor-atKUWr5tajBWk0Htik3J/w@public.gmane.org> wrote:
> >On 6/27/07, Dor Laor <dor.laor-atKUWr5tajBWk0Htik3J/w@public.gmane.org> wrote:
> >> >BTW, I think that turning on debugger from qemu is a dangerous
> action,
> >> >from security point of view. Once the gdbserver is started, anybody
> >> >can connect to it (with gdb) and modify VM memory in anyway he wants
> >> >(like overwrite kernel with malicious code). The problem why this is
> >> >feasible is because there is no authentication machanism on
> gdbserver
> >> >at all.
> >>
> >> How can gdb-ing qemu harm the kernel? Although the whole guest memory
> >> image is mapped to qemu and writable for gdb, kernel data structures
> are
> >> not mapped (except for kvm_run and it has validity checks). So I
> don't
> >> think it's a security hole.
> >
> >You mean kvm_run() maps guest VM at the start, and unmaps it at the
> >end? That is interesting! That is obviously more secure, as when
> >debugger is active, it cannot modify VM.
>
> It's not why I meant.
> Kvm_run is mapped only once after the creation of the vcpu (in
> kvmctl.c).

Ah, we are talking past each other here :-). I thought you mentioned
kvm_run() function instead of kvm_run structure. (The naming system in
KVM is quite confused)

> The guest has ability to change at anytime the content of the kvm_run
> structure but it has no pointers and the values are checked against
> validity check each time the kernel uses it.
> So except for ruining the guest context gdb or malicious user cannot
> harm the kernel or other guests.
>

Again, a misunderstanding here. I wanted to say that gdb client can be
used to modify the kernel of *guest VM*, rather than host kernel.

Many thanks,
Jun

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

Compile error

[Dong, Eddie]

I saw compiler error at current head, does anybody else see too?
41ac4b23696b12fec15191969bc18da42359861d



make -C /lib/modules/2.6.21-rc3/build M=`pwd` "$@"
make[1]: Entering directory `/root/linux-2.6.21-rc3'
  LD      /root/work2/5th/kvm-userspace/kernel/built-in.o
  CC [M]  /root/work2/5th/kvm-userspace/kernel/svm.o
  CC [M]  /root/work2/5th/kvm-userspace/kernel/vmx.o
  CC [M]  /root/work2/5th/kvm-userspace/kernel/vmx-debug.o
  CC [M]  /root/work2/5th/kvm-userspace/kernel/kvm_main.o
/root/work2/5th/kvm-userspace/kernel/kvm_main.c:46:31:
linux/anon_inodes.h: No such file or directory
/root/work2/5th/kvm-userspace/kernel/kvm_main.c: In function
`create_vcpu_fd':
/root/work2/5th/kvm-userspace/kernel/kvm_main.c:2366: warning: implicit
declaration of function `anon_inode_getfd'
make[2]: *** [/root/work2/5th/kvm-userspace/kernel/kvm_main.o] Error 1
make[1]: *** [_module_/root/work2/5th/kvm-userspace/kernel] Error 2
make[1]: Leaving directory `/root/linux-2.6.21-rc3'
make: *** [all] Error 2

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

Re: Compile error

[Dor Laor]

>I saw compiler error at current head, does anybody else see too?
>41ac4b23696b12fec15191969bc18da42359861d
>
>
>
>make -C /lib/modules/2.6.21-rc3/build M=`pwd` "$@"
>make[1]: Entering directory `/root/linux-2.6.21-rc3'
>  LD      /root/work2/5th/kvm-userspace/kernel/built-in.o
>  CC [M]  /root/work2/5th/kvm-userspace/kernel/svm.o
>  CC [M]  /root/work2/5th/kvm-userspace/kernel/vmx.o
>  CC [M]  /root/work2/5th/kvm-userspace/kernel/vmx-debug.o
>  CC [M]  /root/work2/5th/kvm-userspace/kernel/kvm_main.o
>/root/work2/5th/kvm-userspace/kernel/kvm_main.c:46:31:
>linux/anon_inodes.h: No such file or directory
>/root/work2/5th/kvm-userspace/kernel/kvm_main.c: In function
>`create_vcpu_fd':
>/root/work2/5th/kvm-userspace/kernel/kvm_main.c:2366: warning: implicit
>declaration of function `anon_inode_getfd'
>make[2]: *** [/root/work2/5th/kvm-userspace/kernel/kvm_main.o] Error 1
>make[1]: *** [_module_/root/work2/5th/kvm-userspace/kernel] Error 2
>make[1]: Leaving directory `/root/linux-2.6.21-rc3'
>make: *** [all] Error 2


This is the latest change of dropping kvmfs in favor of
anon_inode_getfd.
A matching code should be added to the external_kernel_compat.h file so
older kernels without anonfs could be used.

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

compile error

[Zhao, Yunfeng]

[-- Attachment #1.1: Type: text/plain, Size: 843 bytes --]

I met an error when i build latest KVM on rhel5.

Seems asm/cmpxchg.h is not in the kernel before 2.6.22.

How can I fix the issue?

 

 

make -C kernel

make[1]: Entering directory `/tmp/tmp/kvm-userspace/kernel'

make -C /lib/modules/2.6.18-8.el5/build M=`pwd` "$@"

make[2]: Entering directory `/usr/src/kernels/2.6.18-8.el5-x86_64'

  CC [M]  /tmp/tmp/kvm-userspace/kernel/mmu.o

/tmp/tmp/kvm-userspace/kernel/mmu.c:25:25: error: asm/cmpxchg.h: No such
file or directory

make[3]: *** [/tmp/tmp/kvm-userspace/kernel/mmu.o] Error 1

make[2]: *** [_module_/tmp/tmp/kvm-userspace/kernel] Error 2

make[2]: Leaving directory `/usr/src/kernels/2.6.18-8.el5-x86_64'

make[1]: *** [all] Error 2

make[1]: Leaving directory `/tmp/tmp/kvm-userspace/kernel'

make: *** [kernel] Error 2

 

thanks

Yunfeng


[-- Attachment #1.2: Type: text/html, Size: 4835 bytes --]

[-- Attachment #2: Type: text/plain, Size: 286 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

[-- Attachment #3: Type: text/plain, Size: 186 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/kvm-devel

Re: compile error

[Avi Kivity]

Zhao, Yunfeng wrote:
>
> I met an error when i build latest KVM on rhel5.
>
> Seems asm/cmpxchg.h is not in the kernel before 2.6.22.
>
> How can I fix the issue?
>
>  
>

Add a kernel/include/linux/asm/cmpxchg.h, which defines set_64bit() for
both i386 and x86_64.



-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.


-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/