From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Hoffmann Subject: Re: [PATCH 3/3] [PATCH] kvmclock implementation, the guest part. Date: Fri, 11 Jan 2008 14:23:02 +0100 Message-ID: <47876DB6.3020105@redhat.com> References: <12000570563874-git-send-email-gcosta@redhat.com> <12000570732755-git-send-email-gcosta@redhat.com> <12000570802212-git-send-email-gcosta@redhat.com> <12000570863750-git-send-email-gcosta@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, jeremy-TSDbQ3PG+2Y@public.gmane.org, avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org To: Glauber de Oliveira Costa Return-path: In-Reply-To: <12000570863750-git-send-email-gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Hi, > diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c > index d083ff5..7728b87 100644 > --- a/arch/x86/xen/time.c > +++ b/arch/x86/xen/time.c > -static cycle_t xen_clocksource_read(void); > +cycle_t xen_clocksource_read(void); Huh? You kill the static, but don't use the functions anywhere? Looks like half-done code sharing with xen paravirt clock ... cheers, Gerd ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace