From: Glauber de Oliveira Costa <gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Gerd Hoffmann <kraxel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
jeremy-TSDbQ3PG+2Y@public.gmane.org,
avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org
Subject: Re: [PATCH 3/3] [PATCH] kvmclock implementation, the guest part.
Date: Fri, 11 Jan 2008 11:32:04 -0200 [thread overview]
Message-ID: <47876FD4.9000104@redhat.com> (raw)
In-Reply-To: <47876DB6.3020105-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Gerd Hoffmann wrote:
> Hi,
>
>> diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c
>> index d083ff5..7728b87 100644
>> --- a/arch/x86/xen/time.c
>> +++ b/arch/x86/xen/time.c
>> -static cycle_t xen_clocksource_read(void);
>> +cycle_t xen_clocksource_read(void);
>
> Huh? You kill the static, but don't use the functions anywhere? Looks
> like half-done code sharing with xen paravirt clock ...
>
> cheers,
> Gerd
>
It's called experimentation. I was sure I deleted this part of the patch
altogheter, but I must have
missed it. Thanks for the point out.
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
next prev parent reply other threads:[~2008-01-11 13:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-11 13:10 [PATCH 0/3] KVM clock, new iteration Glauber de Oliveira Costa
[not found] ` <12000570563874-git-send-email-gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2008-01-11 13:10 ` [PATCH 1/3] put kvm_para.h include outside __KERNEL__ Glauber de Oliveira Costa
[not found] ` <12000570732755-git-send-email-gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2008-01-11 13:10 ` [PATCH 2/3] [PATCH] kvmclock - the host part Glauber de Oliveira Costa
[not found] ` <12000570802212-git-send-email-gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2008-01-11 13:10 ` [PATCH 3/3] [PATCH] kvmclock implementation, the guest part Glauber de Oliveira Costa
[not found] ` <12000570863750-git-send-email-gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2008-01-11 13:23 ` Gerd Hoffmann
[not found] ` <47876DB6.3020105-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2008-01-11 13:32 ` Glauber de Oliveira Costa [this message]
2008-01-11 15:47 ` [PATCH 2/3] [PATCH] kvmclock - the host part Anthony Liguori
[not found] ` <47878F8A.4010506-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>
2008-01-12 20:49 ` Avi Kivity
[not found] ` <478927DA.3000800-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2008-01-12 22:51 ` Anthony Liguori
2008-01-12 20:38 ` Avi Kivity
2008-01-11 15:09 ` [PATCH 1/3] put kvm_para.h include outside __KERNEL__ Amit Shah
2008-01-11 15:49 ` [PATCH 0/3] KVM clock, new iteration Anthony Liguori
-- strict thread matches above, loose matches on Subject: below --
2008-01-15 15:10 [PATCH 0/3] kvm clock - with the patches this time Glauber de Oliveira Costa
2008-01-15 15:10 ` [PATCH 1/3] put kvm_para.h include outside __KERNEL__ Glauber de Oliveira Costa
2008-01-15 15:10 ` [PATCH 2/3] kvmclock - the host part Glauber de Oliveira Costa
[not found] ` <12004098373625-git-send-email-gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2008-01-15 15:10 ` [PATCH 3/3] [PATCH] kvmclock implementation, the guest part Glauber de Oliveira Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47876FD4.9000104@redhat.com \
--to=gcosta-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org \
--cc=jeremy-TSDbQ3PG+2Y@public.gmane.org \
--cc=kraxel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox