Re: [PATCH 1/2] include kvm_para.h

[Glauber de Oliveira Costa <gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

Avi Kivity wrote:
> Glauber de Oliveira Costa wrote:
>> have qemu-kvm to include kvm_para, allowing access to paravirt 
>> definitions
>>
>> Signed-off-by: Glauber de Oliveira Costa <gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>> ---
>>  qemu/qemu-kvm-x86.c |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/qemu/qemu-kvm-x86.c b/qemu/qemu-kvm-x86.c
>> index c79ca36..21ec112 100644
>> --- a/qemu/qemu-kvm-x86.c
>> +++ b/qemu/qemu-kvm-x86.c
>> @@ -14,6 +14,7 @@ extern int kvm_irqchip;
>>  #include <libkvm.h>
>>  #include <pthread.h>
>>  #include <sys/utsname.h>
>> +#include <linux/kvm_para.h>
>>  
> 
> IIRC, early versions of kvm_para.h were userspace unfriendly, so we need 
> a version code check (or better, a KVM_CAP_ check) around this.
> 
No need. including kvm_para.h in userspace unfriendly tools won't break 
anything. Code that handles it userspace is already enclosed in the 
KVM_CAP_ check.

(well, in reality, I forgot to enclose one line with it. But it's a bug,
and will be fixed in the series I'm about to shoot out.


-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace