From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [resend] [PATCH] MSR_IA32_PERF_STATUS support Date: Tue, 15 Jan 2008 19:45:40 +0200 Message-ID: <478CF144.7070305@qumranet.com> References: <478CA68D.4050504@csgraf.de> <478CD11A.1030500@qumranet.com> <478CE2BD.7090002@csgraf.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel To: Alexander Graf Return-path: In-Reply-To: <478CE2BD.7090002-r27SGEef+tmzQB+pC5nmwQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Alexander Graf wrote: > Avi Kivity wrote: > >> Alexander Graf wrote: >> >> >>> This is a resend of a mail I sent on 01/10/2008. I did not receive any >>> response, so I assume it was lost. >>> >>> The patch is really minor, does not break any compatibility (the MSR is >>> Intel family 13+) and makes Darwin work. >>> >>> --- old mail --- >>> >>> This patch adds support for the MSR MSR_IA32_PERF_STATUS. This is >>> required to boot Darwin. >>> >>> I only implemented dummy support, as the real value would be of no >>> meaning to any OS I know so far anyway and is only implemented on very >>> recent Intel CPUs. >>> >>> >>> >>> >> Looks okay, but please add a signoff line and use the kernel coding >> style (tabs and comment style). >> >> >> >> >> > Ok, should I resend the patch with a signed-off line and proper coding > style? > Yes please. I'm a little worried that this can confuse other guests, but as it's read only and a large variety have run so far without complaining, it's probably safe enough. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/