From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Hoffmann Subject: Re: [PATCH 2/3] kvmclock - the host part. Date: Wed, 16 Jan 2008 09:54:58 +0100 Message-ID: <478DC662.6010902@redhat.com> References: <1200409817411-git-send-email-gcosta@redhat.com> <120040983179-git-send-email-gcosta@redhat.com> <12004098373625-git-send-email-gcosta@redhat.com> <478DC2CF.4040803@qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, jeremy-TSDbQ3PG+2Y@public.gmane.org, Glauber de Oliveira Costa To: Avi Kivity Return-path: In-Reply-To: <478DC2CF.4040803-atKUWr5tajBWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Hi, > We want to avoid updating wall clock all the time. As far as I > understand, wall clock is just a base which doesn't change. Yep, it is. Got that wrong first in xenner, with the result that guest time ran at double speed ;) >> +/* xen binary-compatible interfaces. See xen headers for details */ >> +struct xen_vcpu_time_info { >> + uint32_t version; >> + uint32_t pad0; >> + uint64_t tsc_timestamp; >> + uint64_t system_time; >> + uint32_t tsc_to_system_mul; >> + int8_t tsc_shift; >> + int8_t pad1[3]; >> +}; >> +struct xen_vcpu_info { >> + uint8_t pad[32]; >> + struct xen_vcpu_time_info time; >> +}; >> > > Please drop xen_vcpu_info... Oh, yeah. No point in assembling the whole xen shared info page. Just xen_vcpu_time_info is enougth, it will work just fine for xenner. cheers, Gerd ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/