From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 2/3] kvmclock - the host part. Date: Wed, 16 Jan 2008 11:32:03 +0200 Message-ID: <478DCF13.7090901@qumranet.com> References: <1200409817411-git-send-email-gcosta@redhat.com> <120040983179-git-send-email-gcosta@redhat.com> <12004098373625-git-send-email-gcosta@redhat.com> <478DC2CF.4040803@qumranet.com> <478DC662.6010902@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, jeremy-TSDbQ3PG+2Y@public.gmane.org, Glauber de Oliveira Costa To: Gerd Hoffmann Return-path: In-Reply-To: <478DC662.6010902-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Gerd Hoffmann wrote: > Hi, > > >> We want to avoid updating wall clock all the time. As far as I >> understand, wall clock is just a base which doesn't change. >> > > Yep, it is. Got that wrong first in xenner, with the result that guest > time ran at double speed ;) > > >>> +/* xen binary-compatible interfaces. See xen headers for details */ >>> +struct xen_vcpu_time_info { >>> + uint32_t version; >>> + uint32_t pad0; >>> + uint64_t tsc_timestamp; >>> + uint64_t system_time; >>> + uint32_t tsc_to_system_mul; >>> + int8_t tsc_shift; >>> + int8_t pad1[3]; >>> +}; >>> > > >>> +struct xen_vcpu_info { >>> + uint8_t pad[32]; >>> + struct xen_vcpu_time_info time; >>> +}; >>> >>> >> Please drop xen_vcpu_info... >> > > Oh, yeah. No point in assembling the whole xen shared info page. Just > xen_vcpu_time_info is enougth, it will work just fine for xenner. > > We should also not use the xen_ namespace, that can only cause conflicts. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/