From: Glauber de Oliveira Costa <gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Gerd Hoffmann <kraxel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
jeremy-TSDbQ3PG+2Y@public.gmane.org,
avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org
Subject: Re: [PATCH 2/2] kvmclock implementation, the guest part.
Date: Thu, 17 Jan 2008 10:52:30 -0200 [thread overview]
Message-ID: <478F4F8E.2060007@redhat.com> (raw)
In-Reply-To: <478F0BBE.1010507-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Gerd Hoffmann wrote:
>> +struct shared_info shared_info __attribute__((__aligned__(PAGE_SIZE)));
>
> leftover from old version?
>
>> +unsigned long kvm_get_wallclock(void)
>> +{
>> + u32 wc_sec, wc_nsec;
>> + u64 delta, last_tsc;
>> + struct timespec ts;
>> + int version, nsec, cpu = smp_processor_id();
>> +
>> + native_write_msr(MSR_KVM_WALL_CLOCK, __pa(&wall_clock));
>
> Huh? Shouldn't that be done once at boot time?
>
> cheers,
> Gerd
>
>
It can, but I don't think so. The closer to read we do, the more
precision we get on unstable tsc systems.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
next prev parent reply other threads:[~2008-01-17 12:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-16 16:31 [PATCH 0/2] kvm clock - xen compatible by accident Glauber de Oliveira Costa
[not found] ` <1200501067774-git-send-email-gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2008-01-16 16:31 ` [PATCH 1/2] kvmclock - the host part Glauber de Oliveira Costa
[not found] ` <12005010761561-git-send-email-gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2008-01-16 16:31 ` [PATCH 2/2] kvmclock implementation, the guest part Glauber de Oliveira Costa
[not found] ` <1200501082989-git-send-email-gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2008-01-17 8:03 ` Gerd Hoffmann
[not found] ` <478F0BBE.1010507-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2008-01-17 12:52 ` Glauber de Oliveira Costa [this message]
2008-01-16 19:00 ` [PATCH 1/2] kvmclock - the host part Anthony Liguori
[not found] ` <478E544C.4020603-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>
2008-01-17 0:18 ` Glauber de Oliveira Costa
2008-01-17 7:59 ` Gerd Hoffmann
2008-01-20 15:37 ` Avi Kivity
2008-01-20 15:38 ` Avi Kivity
-- strict thread matches above, loose matches on Subject: below --
2008-02-11 18:07 [PATCH 0/2] kvm clock - merge last comments Glauber de Oliveira Costa
2008-02-11 18:07 ` [PATCH 1/2] kvmclock - the host part Glauber de Oliveira Costa
2008-02-11 18:07 ` [PATCH 2/2] kvmclock implementation, the guest part Glauber de Oliveira Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=478F4F8E.2060007@redhat.com \
--to=gcosta-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org \
--cc=jeremy-TSDbQ3PG+2Y@public.gmane.org \
--cc=kraxel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox