From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] virtio: remove explicit pci ids from virtio_pci.c Date: Mon, 21 Jan 2008 11:12:46 +0200 Message-ID: <4794620E.7010900@qumranet.com> References: <200801211130.51401.rusty@rustcorp.com.au> <479420D2.7050902@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel , virtualization-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Anthony Liguori Return-path: In-Reply-To: <479420D2.7050902-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Anthony Liguori wrote: > Rusty Russell wrote: >> Qumranet let us use their PCI vendor ID, with device ids >= 0x1000. >> We can specify that we accept all of them in the device ID table, and >> then return -ENODEV in the probe routine. >> > > I thought the device id range was smaller. Avi? > Yes, 0x1000-0x10ff IIRC. Also, if we break compatibility in the future, won't this claim devices we don't actually support? -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/