From: Jan Kiszka <jan.kiszka-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org>
To: "Yang, Sheng" <sheng.yang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
Subject: Re: [RFC][PATCH 1/2] KVM: In-kernel PIT model
Date: Mon, 21 Jan 2008 10:53:26 +0100 [thread overview]
Message-ID: <47946B96.4040508@siemens.com> (raw)
In-Reply-To: <200801211718.23664.sheng.yang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Yang, Sheng wrote:
> --- /dev/null
> +++ b/arch/x86/kvm/i8254.h
...
> +#define PIT_BASE_ADDRESS 0x40
> +#define SPEAKER_BASE_ADDRESS 0x61
> +#define PIT_MEM_LENGTH 4
> +#define PIT_FREQ 1193181
The PIT may not be limited to x86 platforms. So I would propose to make
the setup more generic and flexible. And I would move the code out of
arch/x86, just the speaker support should remain there.
I'm currently struggling with emulating a proprietary platform that has
(among other specialties...) a different PIT base frequency, and I
already had to patch user space qemu for customizable frequencies. Maybe
this kernel extension is a good chance to generalize the PIT setup, and
I would be happy to contribute to this if there is a consensus.
Jan
--
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
next prev parent reply other threads:[~2008-01-21 9:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-21 9:18 [RFC][PATCH 1/2] KVM: In-kernel PIT model Yang, Sheng
[not found] ` <200801211718.23664.sheng.yang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2008-01-21 9:53 ` Jan Kiszka [this message]
[not found] ` <47946B96.4040508-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org>
2008-01-21 10:14 ` Avi Kivity
[not found] ` <47947088.5030309-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2008-01-21 10:22 ` Jan Kiszka
[not found] ` <47947252.7000606-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org>
2008-01-21 10:44 ` Avi Kivity
2008-01-21 10:28 ` Carsten Otte
[not found] ` <479473D0.7000002-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
2008-01-22 1:15 ` Yang, Sheng
2008-01-22 13:54 ` Avi Kivity
[not found] ` <4795F582.7050802-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2008-01-23 6:00 ` Yang, Sheng
[not found] ` <200801231400.36063.sheng.yang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2008-01-23 9:46 ` Avi Kivity
[not found] ` <47970CEE.2050000-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2008-01-24 9:29 ` Yang, Sheng
[not found] ` <200801241729.18787.sheng.yang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2008-01-24 9:26 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47946B96.4040508@siemens.com \
--to=jan.kiszka-kv7wefo6altbdgjk7y7tuq@public.gmane.org \
--cc=avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=sheng.yang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox