Re: [RFC][PATCH 1/2] KVM: In-kernel PIT model

Avi Kivity
2008-01-24T09:26:29Z

Yang, Sheng wrote:
> I updated patch using ktime_get() (Is it too heavy?).
>
>

Shouldn't be. At least on modern hosts.

> And currently all the muldiv64() is used to divide 1e9, which can be insteaded
> by ">> 30" approximately. What's your opinion?
>

Accuracy is more important. And modern processors eat 64-bit divides
for breakfast, they're certainly much less expensive than vmexits.

--
Any sufficiently difficult bug is indistinguishable from a feature.