Re: [PATCH] system_powerdown via acpi power button

[Jan Kiszka <jan.kiszka-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org>]

Guido Guenther wrote:
> On Tue, Jan 22, 2008 at 11:11:00AM +0100, Jan Kiszka wrote:
>>  #if defined(TARGET_I386)
>>  void qemu_system_powerdown(void)
>>  {
>> +    if (!pm_state)
>> +        exit(0);
>>      if(pm_state->pmen & PWRBTN_EN) {
>>          pm_state->pmsts |= PWRBTN_EN;
>>  	pm_update_sci(pm_state);
> This totally defeats the "clean shutdown" purpose of system_powerdown.
> Think of it like: 
>     system_powerdown: hint the system to shutdown cleanly
>     SIGTERM: kill the vm
> This is how things are wired up in libvirt at the moment.

So how to signal a "clean shutdown" to the guest if there is no channel
for this?

My idea was to go the PC way: If the OS is not handling ACPI, hitting
power normally switches the PC off - IIRC.

Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/