From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH] system_powerdown via acpi power button Date: Tue, 22 Jan 2008 13:12:12 +0100 Message-ID: <4795DD9C.3040804@siemens.com> References: <20080103181132.GA1077@bogon.ms20.nix> <4795C134.7030400@siemens.com> <20080122114955.GA28335@bogon.ms20.nix> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Avi Kivity To: Guido Guenther Return-path: In-Reply-To: <20080122114955.GA28335-DVvpyRRQz99DDGxTMhc9XQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Guido Guenther wrote: > On Tue, Jan 22, 2008 at 11:11:00AM +0100, Jan Kiszka wrote: >> #if defined(TARGET_I386) >> void qemu_system_powerdown(void) >> { >> + if (!pm_state) >> + exit(0); >> if(pm_state->pmen & PWRBTN_EN) { >> pm_state->pmsts |= PWRBTN_EN; >> pm_update_sci(pm_state); > This totally defeats the "clean shutdown" purpose of system_powerdown. > Think of it like: > system_powerdown: hint the system to shutdown cleanly > SIGTERM: kill the vm > This is how things are wired up in libvirt at the moment. So how to signal a "clean shutdown" to the guest if there is no channel for this? My idea was to go the PC way: If the OS is not handling ACPI, hitting power normally switches the PC off - IIRC. Jan -- Siemens AG, Corporate Technology, CT SE 2 Corporate Competence Center Embedded Linux ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/