[PATCH] janitor: revert accidental type change

[PATCH] janitor: revert accidental type change

[Jan Kiszka]

While trying to reduce the warning noise (to identify warnings of
homebrewed patches), I also came across this bogus but fortunately
harmless type change in bdrv_commit. Fix below.

Jan


Index: kvm-userspace/qemu/block.c
===================================================================
--- kvm-userspace.orig/qemu/block.c
+++ kvm-userspace/qemu/block.c
@@ -460,7 +460,7 @@ int bdrv_commit(BlockDriverState *bs)
     BlockDriver *drv = bs->drv;
     int64_t i, total_sectors;
     int n, j;
-    unsigned char *sector[512];
+    unsigned char sector[512];

     if (!drv)
         return -ENOMEDIUM;

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

Re: [PATCH] janitor: revert accidental type change

[Laurent Vivier]

Le lundi 21 janvier 2008 à 13:23 +0100, Jan Kiszka a écrit :
> While trying to reduce the warning noise (to identify warnings of
> homebrewed patches), I also came across this bogus but fortunately
> harmless type change in bdrv_commit. Fix below.
> 
> Jan

This has already been reported.

Please apply, Avi.

I'm working on a patch to be able to use snapshot=on and cache=off
together, but while I'm fighting against AIO (I've an incomprehensible
EINVAL) you should apply this fix.

Laurent

> 
> Index: kvm-userspace/qemu/block.c
> ===================================================================
> --- kvm-userspace.orig/qemu/block.c
> +++ kvm-userspace/qemu/block.c
> @@ -460,7 +460,7 @@ int bdrv_commit(BlockDriverState *bs)
>      BlockDriver *drv = bs->drv;
>      int64_t i, total_sectors;
>      int n, j;
> -    unsigned char *sector[512];
> +    unsigned char sector[512];
> 
>      if (!drv)
>          return -ENOMEDIUM;
> 


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel

Re: [PATCH] janitor: revert accidental type change

[Carlo Marcelo Arenas Belon]

On Mon, Jan 21, 2008 at 01:23:40PM +0100, Jan Kiszka wrote:
> While trying to reduce the warning noise (to identify warnings of
> homebrewed patches), I also came across this bogus but fortunately
> harmless type change in bdrv_commit. Fix below

the same fix was proposed before in :

  http://www.mail-archive.com/kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org/msg11246.html

but as you can see in that thread, a more complete change will be needed
to cover for alignment issues when using direct IO (cache=off)

Carlo

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

Re: [PATCH] janitor: revert accidental type change

[Avi Kivity]

Jan Kiszka wrote:
> While trying to reduce the warning noise (to identify warnings of
> homebrewed patches), I also came across this bogus but fortunately
> harmless type change in bdrv_commit. Fix below.
>
>   

Applied, thanks.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/