public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: Andrea Arcangeli <andrea-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH] kvm-userland mm count skew
Date: Tue, 22 Jan 2008 15:41:02 +0200	[thread overview]
Message-ID: <4795F26E.9090807@qumranet.com> (raw)
In-Reply-To: <20080121124455.GI6970-lysg2Xt5kKMAvxtiuMwx3w@public.gmane.org>

Andrea Arcangeli wrote:
> I still can't see how it could be possibly make a difference for the
> mm_count if the kvm module is compiled inside the kernel or as an
> external module, the reference counting there hasn't changed since
> ages. The mmdrop fires only in the first overflow so even if I'm right
> it probably wasn't much destabilizing to go negative given it happened
> at mm destruction time.
>
>   

It's this bit:

> /* __mmdrop() is not exported before 2.6.25 */
> #include <linux/sched.h>
>
> #if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,25)
>
> #define mmdrop(x) do { (void)(x); } while (0)
>
> #endif


-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

  parent reply	other threads:[~2008-01-22 13:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-21 12:44 [PATCH] kvm-userland mm count skew Andrea Arcangeli
     [not found] ` <20080121124455.GI6970-lysg2Xt5kKMAvxtiuMwx3w@public.gmane.org>
2008-01-22 13:41   ` Avi Kivity [this message]
     [not found]     ` <4795F26E.9090807-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2008-01-22 14:25       ` Andrea Arcangeli
     [not found]         ` <20080122142525.GB7331-lysg2Xt5kKMAvxtiuMwx3w@public.gmane.org>
2008-01-22 14:33           ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4795F26E.9090807@qumranet.com \
    --to=avi-atkuwr5tajbwk0htik3j/w@public.gmane.org \
    --cc=andrea-atKUWr5tajBWk0Htik3J/w@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox