From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] kvm-userland mm count skew Date: Tue, 22 Jan 2008 15:41:02 +0200 Message-ID: <4795F26E.9090807@qumranet.com> References: <20080121124455.GI6970@v2.random> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Andrea Arcangeli Return-path: In-Reply-To: <20080121124455.GI6970-lysg2Xt5kKMAvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Andrea Arcangeli wrote: > I still can't see how it could be possibly make a difference for the > mm_count if the kvm module is compiled inside the kernel or as an > external module, the reference counting there hasn't changed since > ages. The mmdrop fires only in the first overflow so even if I'm right > it probably wasn't much destabilizing to go negative given it happened > at mm destruction time. > > It's this bit: > /* __mmdrop() is not exported before 2.6.25 */ > #include > > #if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,25) > > #define mmdrop(x) do { (void)(x); } while (0) > > #endif -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/