From mboxrd@z Thu Jan 1 00:00:00 1970 From: Izik Eidus Subject: Re: kvm-59 doesn't work Date: Wed, 23 Jan 2008 15:18:34 +0200 Message-ID: <47973EAA.2000007@qumranet.com> References: <20080113162751.GA20663@basil.nowhere.org> <478A3F87.6040509@qumranet.com> <478A47E4.8020109@codemonkey.ws> <20080113175922.GA4002@one.firstfloor.org> <478A53BB.30308@qumranet.com> <20080113181704.GA4196@one.firstfloor.org> <478A56BF.8020507@qumranet.com> <20080113183331.GB4196@one.firstfloor.org> <478C9174.6020909@qumranet.com> <20080115115731.GA31275@one.firstfloor.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------010001080906030207070508" Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Avi Kivity To: Andi Kleen Return-path: In-Reply-To: <20080115115731.GA31275-qrUzlfsMFqo/4alezvVtWx2eb7JE58TQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org This is a multi-part message in MIME format. --------------010001080906030207070508 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Andi Kleen wrote: > On Tue, Jan 15, 2008 at 12:56:52PM +0200, Avi Kivity wrote: > >> Andi Kleen wrote: >> >>> FWIW it seems things are broken even without -kernel in -59 too. If I try >>> to boot an existing image with just -hda ... the VGA screen just stays >>> black while the process runs at 99% CPU. Again with -49 it works fine. >>> >>> >>> >> Yes, 6b8bb99a9cde386d72b4b7c22b92f4bdec333dab in kvm-userspace.git ought >> to fix it. >> > > Thanks will try later. How about the oops in 2.6.24 I reported though? > > -Andi > > the bellow patch should fix this opss (it is targeted for 2.6.24-rc7) -- woof. --------------010001080906030207070508 Content-Type: text/x-patch; name="fix-decode.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="fix-decode.patch" >>From cb019c68bea9955d553c3ef6946e3abed357f1c2 Mon Sep 17 00:00:00 2001 From: Izik Eidus Date: Wed, 23 Jan 2008 15:16:26 +0200 Subject: [PATCH] KVM: x86 emulator: fix decoding of registers to dst and src in case of instructions that declared as SrcMem or DstMem, right now for instructions that declared as SrcMem or DstMem we dont decode the registers for dst and src. Signed-off-by: Izik Eidus --- drivers/kvm/x86_emulate.c | 31 ++++++++++++++++++++++++++++++- 1 files changed, 30 insertions(+), 1 deletions(-) diff --git a/drivers/kvm/x86_emulate.c b/drivers/kvm/x86_emulate.c index bd46de6..c5251f4 100644 --- a/drivers/kvm/x86_emulate.c +++ b/drivers/kvm/x86_emulate.c @@ -830,7 +830,21 @@ done_prefixes: */ if ((d & ModRM) && modrm_mod == 3) { src.type = OP_REG; - break; + src.ptr = decode_register(modrm_reg, _regs, 0); + switch ((src.bytes = op_bytes)) { + case 1: + src.val = src.orig_val = *(u8 *) src.ptr; + break; + case 2: + src.val = src.orig_val = *(u16 *) src.ptr; + break; + case 4: + src.val = src.orig_val = *(u32 *) src.ptr; + break; + case 8: + src.val = src.orig_val = *(u64 *) src.ptr; + break; + } } src.type = OP_MEM; src.ptr = (unsigned long *)cr2; @@ -906,6 +920,21 @@ done_prefixes: */ if ((d & ModRM) && modrm_mod == 3) { dst.type = OP_REG; + dst.ptr = decode_register(modrm_reg, _regs, 0); + switch ((dst.bytes = op_bytes)) { + case 1: + dst.val = *(u8 *)dst.ptr; + break; + case 2: + dst.val = *(u16 *)dst.ptr; + break; + case 4: + dst.val = *(u32 *)dst.ptr; + break; + case 8: + dst.val = *(u64 *)dst.ptr; + break; + } break; } if (d & BitOp) { -- 1.5.3.6 --------------010001080906030207070508 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ --------------010001080906030207070508 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kvm-devel mailing list kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org https://lists.sourceforge.net/lists/listinfo/kvm-devel --------------010001080906030207070508--