From mboxrd@z Thu Jan 1 00:00:00 1970 From: Izik Eidus Subject: Re: kvm-59 doesn't work Date: Wed, 23 Jan 2008 15:29:22 +0200 Message-ID: <47974132.40909@qumranet.com> References: <20080113162751.GA20663@basil.nowhere.org> <478A3F87.6040509@qumranet.com> <478A47E4.8020109@codemonkey.ws> <20080113175922.GA4002@one.firstfloor.org> <478A53BB.30308@qumranet.com> <20080113181704.GA4196@one.firstfloor.org> <478A56BF.8020507@qumranet.com> <20080113183331.GB4196@one.firstfloor.org> <478C9174.6020909@qumranet.com> <20080115115731.GA31275@one.firstfloor.org> <47973EAA.2000007@qumranet.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------070306000001020103010405" Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Avi Kivity To: Andi Kleen Return-path: In-Reply-To: <47973EAA.2000007-atKUWr5tajBWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org This is a multi-part message in MIME format. --------------070306000001020103010405 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Izik Eidus wrote: > Andi Kleen wrote: >> On Tue, Jan 15, 2008 at 12:56:52PM +0200, Avi Kivity wrote: >> >>> Andi Kleen wrote: >>> >>>> FWIW it seems things are broken even without -kernel in -59 too. If >>>> I try >>>> to boot an existing image with just -hda ... the VGA screen just stays >>>> black while the process runs at 99% CPU. Again with -49 it works fine. >>>> >>>> >>>> >>> Yes, 6b8bb99a9cde386d72b4b7c22b92f4bdec333dab in kvm-userspace.git >>> ought to fix it. >>> >> >> Thanks will try later. How about the oops in 2.6.24 I reported though? >> >> -Andi >> >> > the bellow patch should fix this opss > (it is targeted for 2.6.24-rc7) > sorry i forgat one break in this patch this is the fixed patch. -- woof. --------------070306000001020103010405 Content-Type: text/x-patch; name="fix-decode2.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="fix-decode2.patch" commit c481bc1108ebf293b7ea23c478378f360ef51758 Author: Izik Eidus Date: Wed Jan 23 15:16:26 2008 +0200 KVM: x86 emulator: fix decoding of registers to dst and src in case of instructions that declared as SrcMem or DstMem, right now for instructions that declared as SrcMem or DstMem we dont decode the registers for dst and src. Signed-off-by: Izik Eidus diff --git a/drivers/kvm/x86_emulate.c b/drivers/kvm/x86_emulate.c index bd46de6..1764afe 100644 --- a/drivers/kvm/x86_emulate.c +++ b/drivers/kvm/x86_emulate.c @@ -830,6 +830,21 @@ done_prefixes: */ if ((d & ModRM) && modrm_mod == 3) { src.type = OP_REG; + src.ptr = decode_register(modrm_reg, _regs, 0); + switch ((src.bytes = op_bytes)) { + case 1: + src.val = src.orig_val = *(u8 *) src.ptr; + break; + case 2: + src.val = src.orig_val = *(u16 *) src.ptr; + break; + case 4: + src.val = src.orig_val = *(u32 *) src.ptr; + break; + case 8: + src.val = src.orig_val = *(u64 *) src.ptr; + break; + } break; } src.type = OP_MEM; @@ -906,6 +921,21 @@ done_prefixes: */ if ((d & ModRM) && modrm_mod == 3) { dst.type = OP_REG; + dst.ptr = decode_register(modrm_reg, _regs, 0); + switch ((dst.bytes = op_bytes)) { + case 1: + dst.val = *(u8 *)dst.ptr; + break; + case 2: + dst.val = *(u16 *)dst.ptr; + break; + case 4: + dst.val = *(u32 *)dst.ptr; + break; + case 8: + dst.val = *(u64 *)dst.ptr; + break; + } break; } if (d & BitOp) { --------------070306000001020103010405 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ --------------070306000001020103010405 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kvm-devel mailing list kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org https://lists.sourceforge.net/lists/listinfo/kvm-devel --------------070306000001020103010405--