From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: Jan Kiszka <jan.kiszka-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH] qemu: fix some warnings
Date: Thu, 24 Jan 2008 08:34:48 +0200 [thread overview]
Message-ID: <47983188.3010608@qumranet.com> (raw)
In-Reply-To: <479498B9.1000005-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org>
Jan Kiszka wrote:
> Jan Kiszka wrote:
>
>> At this chance, can anyone comment on these uint32_t types?
>>
>> static int subpage_register (subpage_t *mmio, uint32_t start, uint32_t end,
>> int memory);
>> static void *subpage_init (target_phys_addr_t base, uint32_t *phys,
>> int orig_memory);
>>
>> Shouldn't they be target_phys_addr_t? Can't this cause troubles when
>> building 64-bit targets? Looks like it's even a generic qemu issue.
>>
>
> At least it should cause no harm to convert to target_phys_addr_t, so
> here is a cleanup patch for qemu/exec.c.
>
>
Please post these patches to qemu-devel, in order to limit the
divergence between kvm's version of qemu and upstream.
--
Any sufficiently difficult bug is indistinguishable from a feature.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
next prev parent reply other threads:[~2008-01-24 6:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-21 12:46 [PATCH] qemu: fix some warnings Jan Kiszka
[not found] ` <47949413.4060804-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org>
2008-01-21 13:06 ` Jan Kiszka
[not found] ` <479498B9.1000005-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org>
2008-01-21 14:00 ` Carlo Marcelo Arenas Belon
2008-01-24 6:34 ` Avi Kivity [this message]
2008-01-21 14:22 ` Carlo Marcelo Arenas Belon
2008-01-22 10:06 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47983188.3010608@qumranet.com \
--to=avi-atkuwr5tajbwk0htik3j/w@public.gmane.org \
--cc=jan.kiszka-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox