From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] qemu: fix some warnings Date: Thu, 24 Jan 2008 08:34:48 +0200 Message-ID: <47983188.3010608@qumranet.com> References: <47949413.4060804@siemens.com> <479498B9.1000005@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Jan Kiszka Return-path: In-Reply-To: <479498B9.1000005-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Jan Kiszka wrote: > Jan Kiszka wrote: > >> At this chance, can anyone comment on these uint32_t types? >> >> static int subpage_register (subpage_t *mmio, uint32_t start, uint32_t end, >> int memory); >> static void *subpage_init (target_phys_addr_t base, uint32_t *phys, >> int orig_memory); >> >> Shouldn't they be target_phys_addr_t? Can't this cause troubles when >> building 64-bit targets? Looks like it's even a generic qemu issue. >> > > At least it should cause no harm to convert to target_phys_addr_t, so > here is a cleanup patch for qemu/exec.c. > > Please post these patches to qemu-devel, in order to limit the divergence between kvm's version of qemu and upstream. -- Any sufficiently difficult bug is indistinguishable from a feature. ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/