Re: [PATCH]: Make migration handle errors a little better

Chris Lalancette
2008-01-24T19:22:43Z

Uri Lublin wrote:
>
> Chris Lalancette wrote:
>> All,
>> Attached is a fairly simple patch to the migration code to make it handle
>> errors better. In particular, if the remote side wasn't set up properly (i.e.
>> the memory size didn't match), the migration would fail, but the source host
>> didn't actually react properly, so the migration would still be "in-progress".
>> This patch fixes up the error checking to properly quit when the remote side
>> isn't prepared for whatever reason.
>>
>> Signed-off-by: Chris Lalancette <clalance-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>>
> Patch looks good.
> Why did you define MIG_STAT_DIRTY_TRACK_FAIL and not
> MIG_STAT_KVM_SET_DIRTY_TRACKING_FAILED ?

Heh. I was just being lazy, and I didn't want to type all of that :). I can
change it to be more correct, though.

> Also we need to make sure, in case of a failure, that 'status' is
> updated and *s->has_error is freed. How about calling migrate_finish ?

Oh, good point. I thought calling migrate_close() would be enough, but it looks
like you are right, we also need to free up has_error. I'll send an updated patch.

Thanks for the review!
Chris Lalancette