From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] system_powerdown via acpi power button Date: Thu, 24 Jan 2008 14:54:02 +0200 Message-ID: <47988A6A.2030907@qumranet.com> References: <20080103181132.GA1077@bogon.ms20.nix> <4795C134.7030400@siemens.com> <20080122114955.GA28335@bogon.ms20.nix> <4795DD9C.3040804@siemens.com> <20080124123730.GA4527@bogon.ms20.nix> <47988797.8040208@qumranet.com> <479889B1.6030403@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Jan Kiszka , Guido Guenther To: Gerd Hoffmann Return-path: In-Reply-To: <479889B1.6030403-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Gerd Hoffmann wrote: > Avi Kivity wrote: > >> Agree, but should try a "quit" monitor command first. Signals are racy, >> like anything that deals with pids (qemu dies, another process is >> fork()ed with the same pid, libvirt kills it). >> > > There is no race in that specific case because qemu is started by > libvirtd. libvirtd can savely kill qemu as long as it hasn't collected > the exit status via waitpid(). While the qemu zombie hangs around the > pid will not be reused. > > Ah good. It does mean that the we can't recover from an untimely libvirtd death, but I'd consider it a reasonable tradeoff. -- Any sufficiently difficult bug is indistinguishable from a feature. ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/