From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1 of 2] Define and use CONFIG_KVM_HAS_PIO so that we don't need pio_data in kvm_arch_vcpu Date: Thu, 24 Jan 2008 15:14:21 +0200 Message-ID: <47988F2D.5090106@qumranet.com> References: <7fa5947a2da8c0c7424e.1200434385@basalt> <47934974.2020107@qumranet.com> <47988BA1.80507@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, kvm-ppc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Hollis Blanchard To: carsteno-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org Return-path: In-Reply-To: <47988BA1.80507-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Carsten Otte wrote: > Avi Kivity wrote: >> Too much Kconfig for this. Since I want to do some Kconfig changes >> anyway, I'll do this another way. > I think you overlooked something here. Actually this should change too > if we don't have pio: > -.......case KVM_GET_VCPU_MMAP_SIZE: > -.......-.......r = -EINVAL; > -.......-.......if (arg) > -.......-.......-.......goto out; > -.......-.......r = 2 * PAGE_SIZE; > -.......-.......break; > Right you are. Fixup patch pushed. Thanks. -- Any sufficiently difficult bug is indistinguishable from a feature. ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/