Uri Lublin wrote: > Patch looks good. > Why did you define MIG_STAT_DIRTY_TRACK_FAIL and not > MIG_STAT_KVM_SET_DIRTY_TRACKING_FAILED ? Oops, I slightly misunderstood this bit in my last e-mail. You were saying that there is already a "MIG_STAT_KVM_SET_DIRTY_TRACKING_FAILED" error flag. In the new patch (attached), I've used this instead. > Also we need to make sure, in case of a failure, that 'status' is > updated and *s->has_error is freed. How about calling migrate_finish ? And I now call migrate_finish() instead of migrate_close() in the error path, as you suggest. Thanks again! Signed-off-by: Chris Lalancette