Re: [PATCH] KVM: VMX: Enable Virtual Processor Identification (VPID)

Avi Kivity
2008-01-25T06:52:47Z

Yang, Sheng wrote:
> Here is the updated patch:
>
>

Applied, thanks.

> @@ -1714,6 +1788,8 @@ static int vmx_vcpu_reset(struct kvm_vcpu *vcpu)
> vmx_fpu_activate(&vmx->vcpu);
> update_exception_bitmap(&vmx->vcpu);
>
> + vpid_sync_all();
> +
> return 0;
>
>

This causes the new instruction to be executed unconditionally, which
would #UD on older processors, no? I replaced it with
vpid_sync_vcpu_all() which seems sufficient, or do I miss something?

--
Any sufficiently difficult bug is indistinguishable from a feature.