From: Avi Kivity <avi@qumranet.com>
To: Joerg Roedel <joro@8bytes.org>
Cc: "Nakajima, Jun" <jun.nakajima@intel.com>,
kvm-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [kvm-devel] [PATCH 3/8] SVM: add module parameter to disable NestedPaging
Date: Sat, 26 Jan 2008 20:23:11 +0200 [thread overview]
Message-ID: <479B7A8F.8070308@qumranet.com> (raw)
In-Reply-To: <20080126072556.GB21476@8bytes.org>
Joerg Roedel wrote:
> Generally I see no problem with it. But at least for NPT I don't see a
> reason why someone should want to disable it on a VM basis (as far as it
> works stable). Avi, what do you think?
>
Unless there is a real-life workload that benefits from npt=0, I see no
reason to have per-vm npt control. The module parameter is helpful, for
to isolate npt problems and for development, but I don't see a need for
users to fiddle with it.
--
Any sufficiently difficult bug is indistinguishable from a feature.
next prev parent reply other threads:[~2008-01-26 18:23 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-25 20:53 [PATCH][RFC] SVM: Add Support for Nested Paging in AMD Fam16 CPUs Joerg Roedel
2008-01-25 20:53 ` [PATCH 3/8] SVM: add module parameter to disable Nested Paging Joerg Roedel
[not found] ` <1201294393-22613-4-git-send-email-joerg.roedel-5C7GfCeVMHo@public.gmane.org>
2008-01-25 21:35 ` Anthony Liguori
[not found] ` <479A561B.8070009-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>
2008-01-25 22:10 ` Joerg Roedel
[not found] ` <20080125221029.GA23111-5C7GfCeVMHo@public.gmane.org>
2008-01-26 18:38 ` Avi Kivity
2008-01-26 1:47 ` [PATCH 3/8] SVM: add module parameter to disable NestedPaging Nakajima, Jun
[not found] ` <2D848F959C03D945A84E9EDE7F7BFE4274021D-7XlYjKTK0pM64kNsxIetb7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2008-01-26 7:25 ` Joerg Roedel
[not found] ` <20080126072556.GB21476-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2008-01-26 9:49 ` Alexey Eremenko
[not found] ` <7fac565a0801260149j7d6d48demfb49d2bb0d5a952-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-01-26 10:06 ` Joerg Roedel
2008-01-26 16:36 ` Anthony Liguori
2008-01-26 18:23 ` Avi Kivity [this message]
[not found] ` <1201294393-22613-1-git-send-email-joerg.roedel-5C7GfCeVMHo@public.gmane.org>
2008-01-25 20:53 ` [PATCH 1/8] SVM: move feature detection to hardware setup code Joerg Roedel
2008-01-25 20:53 ` [PATCH 2/8] SVM: add detection of Nested Paging feature Joerg Roedel
2008-01-25 20:53 ` [PATCH 4/8] X86: export information about NPT to generic x86 code Joerg Roedel
[not found] ` <1201294393-22613-5-git-send-email-joerg.roedel-5C7GfCeVMHo@public.gmane.org>
2008-01-25 21:37 ` Anthony Liguori
[not found] ` <479A56B2.7010306-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>
2008-01-25 21:40 ` Anthony Liguori
2008-01-27 8:40 ` Avi Kivity
2008-01-25 20:53 ` [PATCH 5/8] MMU: make the __nonpaging_map function generic Joerg Roedel
2008-01-25 20:53 ` [PATCH 6/8] X86: export the load_pdptrs() function to modules Joerg Roedel
2008-01-25 20:53 ` [PATCH 7/8] MMU: add HAP support to the KVM MMU Joerg Roedel
2008-01-25 20:53 ` [PATCH 8/8] SVM: add support for Nested Paging Joerg Roedel
[not found] ` <1201294393-22613-9-git-send-email-joerg.roedel-5C7GfCeVMHo@public.gmane.org>
2008-01-27 8:52 ` Avi Kivity
[not found] ` <479C464E.2060009-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2008-01-27 9:41 ` Joerg Roedel
[not found] ` <20080127094147.GA32677-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2008-01-27 9:51 ` Avi Kivity
[not found] ` <479C540A.8020003-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2008-01-27 10:05 ` Joerg Roedel
[not found] ` <20080127100517.GC32677-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2008-01-27 10:24 ` Avi Kivity
2008-01-25 21:32 ` [PATCH][RFC] SVM: Add Support for Nested Paging in AMD Fam16 CPUs Anthony Liguori
[not found] ` <479A5589.7030201-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>
2008-01-25 22:47 ` Joerg Roedel
2008-01-26 1:57 ` Nakajima, Jun
2008-01-27 8:57 ` Avi Kivity
[not found] ` <479C4763.1080104-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2008-01-27 9:51 ` Joerg Roedel
2008-01-28 3:20 ` Jeremy Fitzhardinge
[not found] ` <479D4A0C.5080208-TSDbQ3PG+2Y@public.gmane.org>
2008-01-28 11:08 ` Avi Kivity
2008-02-07 12:09 ` Joerg Roedel
2008-02-10 10:35 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=479B7A8F.8070308@qumranet.com \
--to=avi@qumranet.com \
--cc=joro@8bytes.org \
--cc=jun.nakajima@intel.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox