From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [kvm-devel] [PATCH 3/8] SVM: add module parameter to disable NestedPaging Date: Sat, 26 Jan 2008 20:23:11 +0200 Message-ID: <479B7A8F.8070308@qumranet.com> References: <1201294393-22613-1-git-send-email-joerg.roedel@amd.com> <1201294393-22613-4-git-send-email-joerg.roedel@amd.com> <2D848F959C03D945A84E9EDE7F7BFE4274021D@orsmsx424.amr.corp.intel.com> <20080126072556.GB21476@8bytes.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "Nakajima, Jun" , kvm-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org To: Joerg Roedel Return-path: In-Reply-To: <20080126072556.GB21476@8bytes.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org Joerg Roedel wrote: > Generally I see no problem with it. But at least for NPT I don't see a > reason why someone should want to disable it on a VM basis (as far as it > works stable). Avi, what do you think? > Unless there is a real-life workload that benefits from npt=0, I see no reason to have per-vm npt control. The module parameter is helpful, for to isolate npt problems and for development, but I don't see a need for users to fiddle with it. -- Any sufficiently difficult bug is indistinguishable from a feature.