Re: [PATCH 8/8] SVM: add support for Nested Paging

Avi Kivity
2008-01-27T09:51:06Z

Joerg Roedel wrote:
>
>> What happens to lazy fpu if we don't trap cr0 changes?
>>
>> Perhaps it's worth disabling lazy fpu with npt.
>>
>
> It should be implicitly disabled with npt because accesses to cr3 are
> not intercepted anymore. The svm_set_cr3 function is the only place
> which disables fpu switching.
>

Okay. We may want to investigate enabling it later, but no hurry now.

On the other hand, we want to trap cr0 so the guest can't control the
cache disable bits. Also cr4.pce and cr4.mce.

--
error compiling committee.c: too many arguments to function