public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: Anthony Liguori <aliguori-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH] Update virtio to latest ABI
Date: Mon, 28 Jan 2008 12:49:51 +0200	[thread overview]
Message-ID: <479DB34F.8080001@qumranet.com> (raw)
In-Reply-To: <479D0E7B.2060400-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>

Anthony Liguori wrote:
>>
>> This ABI breakage is worrying.  While it is expected to take some 
>> time for the ABI to congeal, we need some way to prevent mismatched 
>> guests and hosts from running.  Perhaps something like the kvm abi 
>> version, storedin the pci revision field?  Keep incrementing it until 
>> we are satisfied, then use feature bits to add functionality.
>
> This breakage wasn't actually necessary.  We could have used a feature 
> bit to indicate the additional net config field.  In the very least, 
> the additional net config field could have been added to the end of 
> the config space so that old guests kept working that didn't use GSO.
>
> I don't think we need another mechanism to avoid breakages in the 
> future.  I think we have to declare that whatever ships in 2.6.25 is 
> the stable ABI and make sure not to break it again in the future.

I'm worried about the ramp up to 2.6.25 causing confusion among users as 
before that things will break left and right, if we don't provide a 
tighter check.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

  parent reply	other threads:[~2008-01-28 10:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-24 20:00 [PATCH] Update virtio to latest ABI Anthony Liguori
     [not found] ` <12012048063315-git-send-email-aliguori-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-01-27  7:18   ` Avi Kivity
     [not found]     ` <479C3049.1010509-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2008-01-27 23:06       ` Anthony Liguori
     [not found]         ` <479D0E7B.2060400-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-01-28 10:49           ` Avi Kivity [this message]
     [not found]             ` <479DB34F.8080001-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2008-01-28 16:01               ` Anthony Liguori
     [not found]                 ` <479DFC3E.8020709-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-01-28 17:26                   ` Avi Kivity
     [not found]                     ` <479E104A.2040405-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2008-01-28 18:28                       ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=479DB34F.8080001@qumranet.com \
    --to=avi-atkuwr5tajbwk0htik3j/w@public.gmane.org \
    --cc=aliguori-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox