From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 2/2] kvm: libkvm/qemu: Support in-kernel PIT model Date: Mon, 28 Jan 2008 14:00:53 +0200 Message-ID: <479DC3F5.8010703@qumranet.com> References: <200801281446.30147.sheng.yang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: "Yang, Sheng" Return-path: In-Reply-To: <200801281446.30147.sheng.yang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Yang, Sheng wrote: > +void kvm_create_pit(kvm_context_t kvm) > +{ > + int r; > + > + if (!kvm->no_pit_creation) { > + r = ioctl(kvm->fd, KVM_CHECK_EXTENSION, KVM_CAP_PIT); > + if (r > 0) { > + r = ioctl(kvm->vm_fd, KVM_CREATE_PIT); > + if (r < 0) > + printf("Create kernel PIC irqchip failed\n"); > + } > + } > +} > > Need to protect this with #ifdef KVM_CAP_PIT to support compilation with older kernels. If support is not available, qemu should fall back to userspace pit. Please separate the qemu and libkvm parts. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/