From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: Marcelo Tosatti <marcelo-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org>
Cc: kvm-devel <kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: [RFC] VMX CR3 cache
Date: Mon, 28 Jan 2008 19:23:38 +0200 [thread overview]
Message-ID: <479E0F9A.8040609@qumranet.com> (raw)
In-Reply-To: <20080128160444.GA3821@dmt>
Marcelo Tosatti wrote:
> So the questions are, why the benefit is not similar (vm-exit's are now
> way cheaper?) and is it worth to merge this given the results?
>
Yes, vmexits are now about 5 times faster compared to older kvm.
> +
> +/*
> + * Avoid the VM exit upon cr3 load by using the cached
> + * ->active_mm->pgd value:
> + */
> +static void kvm_flush_tlb_user(void)
> +{
> + kvm_write_cr3(__pa(current->active_mm->pgd));
> +}
Would be nice to get this for non-paravirt kernels (perhaps by keeping
__pa(pgd) in a pda variable, instead of reading it through current).
--
error compiling committee.c: too many arguments to function
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
next prev parent reply other threads:[~2008-01-28 17:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-28 16:04 [RFC] VMX CR3 cache Marcelo Tosatti
2008-01-28 17:17 ` Ingo Molnar
[not found] ` <20080128171734.GA19705-X9Un+BFzKDI@public.gmane.org>
2008-01-28 17:35 ` Marcelo Tosatti
2008-01-28 17:37 ` Ingo Molnar
[not found] ` <20080128173707.GB22487-X9Un+BFzKDI@public.gmane.org>
2008-01-28 18:17 ` Marcelo Tosatti
2008-01-28 17:23 ` Avi Kivity [this message]
2008-01-29 8:54 ` Gerd Hoffmann
[not found] ` <479EE9C3.8000007-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2008-01-29 10:28 ` Gerd Hoffmann
[not found] ` <479EFFB0.1000700-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2008-01-29 10:32 ` Gerd Hoffmann
2008-01-29 12:33 ` Marcelo Tosatti
2008-01-30 8:26 ` Gerd Hoffmann
[not found] ` <47A034CD.9010708-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2008-01-30 9:18 ` Gerd Hoffmann
[not found] ` <47A040E3.7000207-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2008-01-30 10:10 ` Avi Kivity
[not found] ` <47A04D1C.4090505-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2008-01-30 12:05 ` Gerd Hoffmann
2008-01-30 13:25 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=479E0F9A.8040609@qumranet.com \
--to=avi-atkuwr5tajbwk0htik3j/w@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=marcelo-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox