Re: [RFC] VMX CR3 cache

Avi Kivity
2008-01-30T10:10:36Z

Gerd Hoffmann wrote:
> Gerd Hoffmann wrote:
>
>> I've passed in a physical address. The vmx_cr3_cache_msr() function has
>> a gva_to_page() call which makes me suspect it expects a virtual
>> address.
>>
>
> Confirmed. When passing in a virtual address it works.
> And it gives me a nice speedup for kernel builds:
>
>
>

[fairly amazing results. how do they compare to xen?]

> I strongly support cr3 caching being merged

Yes, the improvement for xenner alone justifies this. I still doubt
anything else would benefit though.

> (after being cleaned up of
> course).
>

One of the cleanups being using physical addresses in msrs.

--
error compiling committee.c: too many arguments to function