From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] Update virtio to latest ABI Date: Mon, 28 Jan 2008 19:26:34 +0200 Message-ID: <479E104A.2040405@qumranet.com> References: <12012048063315-git-send-email-aliguori@us.ibm.com> <479C3049.1010509@qumranet.com> <479D0E7B.2060400@us.ibm.com> <479DB34F.8080001@qumranet.com> <479DFC3E.8020709@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Anthony Liguori Return-path: In-Reply-To: <479DFC3E.8020709-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Anthony Liguori wrote: >> >> I'm worried about the ramp up to 2.6.25 causing confusion among users >> as before that things will break left and right, if we don't provide >> a tighter check. >> > > Well, using the PCI revision ID isn't a bad idea. It wouldn't have > helped this last problem because that was an ABI break in the network > driver and we really can't indicate a ABI break in the PCI driver for > any possibly virtio device. Why not? we have one pci device per virtio device, and in the same way the pci id is device-specific, the revision id can be device specific as well. We just need a virtio revision field, and a pci-virtio binding for that field. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/