From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: swapping with MMU Notifiers V2 Date: Tue, 29 Jan 2008 18:24:12 +0200 Message-ID: <479F532C.1020503@qumranet.com> References: <20080129145021.GJ7233@v2.random> <479F50D6.4020005@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Andrea Arcangeli To: carsteno-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org Return-path: In-Reply-To: <479F50D6.4020005-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Carsten Otte wrote: >> #include >> @@ -118,6 +119,7 @@ struct kvm { >> struct kvm_io_bus pio_bus; >> struct kvm_vm_stat stat; >> struct kvm_arch arch; >> + struct mmu_notifier mmu_notifier; >> }; >> >> /* The guest did something we don't support. */ >> > This should not be in struct kvm, it should go to x86's kvm_arch. This > is x86 specific, we don't need a notifier since the core-vm will just > page out our guest memory like regular userspace mem. > > Every arch except s390 needs it. An ugly #ifndef CONFIG_KVM_HARDWARE_TLB_SYNC is preferred to duplicating the code. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/