From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Lalancette Subject: Re: [PATCH] Use CONFIG_PREEMPT_NOTIFIERS around struct preempt_notifier Date: Tue, 29 Jan 2008 18:22:29 -0500 Message-ID: <479FB535.5080302@redhat.com> References: <6a2f4869cf5da00fa0cc.1201563754@basalt> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, kvm-ppc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Avi Kivity To: Hollis Blanchard Return-path: In-Reply-To: <6a2f4869cf5da00fa0cc.1201563754@basalt> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Hollis Blanchard wrote: > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > --- a/include/linux/kvm_host.h > +++ b/include/linux/kvm_host.h > @@ -67,7 +67,9 @@ void kvm_io_bus_register_dev(struct kvm_ > = > struct kvm_vcpu { > struct kvm *kvm; > +#ifdef CONFIG_PREEMPT_NOTIFIERS > struct preempt_notifier preempt_notifier; > +#endif > int vcpu_id; > struct mutex mutex; > int cpu; Hm, this causes my build to fail on x86_64: make -C /lib/modules/2.6.23.8-63.fc8/build M=3D`pwd` "$@" make[2]: Entering directory `/usr/src/kernels/2.6.23.8-63.fc8-x86_64' LD /tmp/kvm-userspace/kernel/built-in.o CC [M] /tmp/kvm-userspace/kernel/svm.o CC [M] /tmp/kvm-userspace/kernel/vmx.o CC [M] /tmp/kvm-userspace/kernel/vmx-debug.o CC [M] /tmp/kvm-userspace/kernel/kvm_main.o /tmp/kvm-userspace/kernel/kvm_main.c: In function =91vcpu_load=92: /tmp/kvm-userspace/kernel/kvm_main.c:82: error: =91struct kvm_vcpu=92 has n= o member named =91preempt_notifier=92 /tmp/kvm-userspace/kernel/kvm_main.c: In function =91vcpu_put=92: /tmp/kvm-userspace/kernel/kvm_main.c:91: error: =91struct kvm_vcpu=92 has n= o member named =91preempt_notifier=92 /tmp/kvm-userspace/kernel/kvm_main.c: In function =91kvm_vm_ioctl_create_vc= pu=92: /tmp/kvm-userspace/kernel/kvm_main.c:749: error: =91struct kvm_vcpu=92 has = no member named =91preempt_notifier=92 /tmp/kvm-userspace/kernel/kvm_main.c: In function =91preempt_notifier_to_vc= pu=92: /tmp/kvm-userspace/kernel/kvm_main.c:1284: error: =91struct kvm_vcpu=92 has= no member named =91preempt_notifier=92 /tmp/kvm-userspace/kernel/kvm_main.c:1284: warning: type defaults to =91int= =92 in declaration of =91__mptr=92 /tmp/kvm-userspace/kernel/kvm_main.c:1284: warning: initialization from incompatible pointer type /tmp/kvm-userspace/kernel/kvm_main.c:1284: error: =91struct kvm_vcpu=92 has= no member named =91preempt_notifier=92 make[3]: *** [/tmp/kvm-userspace/kernel/kvm_main.o] Error 1 make[2]: *** [_module_/tmp/kvm-userspace/kernel] Error 2 make[2]: Leaving directory `/usr/src/kernels/2.6.23.8-63.fc8-x86_64' make[1]: *** [all] Error 2 make[1]: Leaving directory `/tmp/kvm-userspace/kernel' make: *** [kernel] Error 2 Reverting this patch makes the build succeed again. Chris Lalancette ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/