From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [RFC] VMX CR3 cache Date: Wed, 30 Jan 2008 12:10:36 +0200 Message-ID: <47A04D1C.4090505@qumranet.com> References: <20080128160444.GA3821@dmt> <479EE9C3.8000007@redhat.com> <479EFFB0.1000700@redhat.com> <20080129123355.GA11587@dmt> <47A034CD.9010708@redhat.com> <47A040E3.7000207@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm-devel To: Gerd Hoffmann Return-path: In-Reply-To: <47A040E3.7000207-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Gerd Hoffmann wrote: > Gerd Hoffmann wrote: > >> I've passed in a physical address. The vmx_cr3_cache_msr() function has >> a gva_to_page() call which makes me suspect it expects a virtual >> address. >> > > Confirmed. When passing in a virtual address it works. > And it gives me a nice speedup for kernel builds: > > > [fairly amazing results. how do they compare to xen?] > I strongly support cr3 caching being merged Yes, the improvement for xenner alone justifies this. I still doubt anything else would benefit though. > (after being cleaned up of > course). > One of the cleanups being using physical addresses in msrs. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/