From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Lalancette Subject: Re: [PATCH]: Fix memory corruption in-kernel IOAPIC emulation Date: Wed, 30 Jan 2008 08:28:08 -0500 Message-ID: <47A07B68.6070303@redhat.com> References: <479FB5C6.6060204@redhat.com> <47A04BB3.7020302@qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Avi Kivity Return-path: In-Reply-To: <47A04BB3.7020302-atKUWr5tajBWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Avi Kivity wrote: > > Excellent catch, but the fix is wrong. Instead of partially restoring > the ioapic state in the kernel, you should fully save it in qemu. > > This is a trap that many fall into: considering kvm and qemu as one > entity and making sure they work well together. We need to make sure > that kvm and libkvm are useful for other userspace programs as well. > Ah. Yeah, that makes sense. OK, I'll work up another patch that does that. Thanks for the feedback. Chris Lalancette ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/