From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] Converting mmio to port io in userspace for IA64 Date: Thu, 31 Jan 2008 09:15:38 +0200 Message-ID: <47A1759A.1080208@qumranet.com> References: <42DFA526FC41B1429CE7279EF83C6BDCD31CCB@pdsmsx415.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, kvm-ia64-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: "Zhang, Xiantao" Return-path: In-Reply-To: <42DFA526FC41B1429CE7279EF83C6BDCD31CCB-wq7ZOvIWXbMAbVU2wMM1CrfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Zhang, Xiantao wrote: > From: Zhang Xiantao > Date: Thu, 31 Jan 2008 09:06:21 +0800 > Subject: [PATCH] kvm: qemu: Covert the mmio address space to port io in > userspace. > > IA64 also have no port io, but chipset is responsible for converting > some mmio to port io for keeping compatibility with legacy deviceS. > @@ -56,6 +56,60 @@ static fdctrl_t *floppy_controller; > static RTCState *rtc_state; > static PCIDevice *i440fx_state; > > +#define TO_LEGACY_IO(addr) (((addr&0x3ffffff) >> 12 << 2)|((addr) & > 0x3)) > Please change to a function. Other than that, patch looks good. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/